[PATCH] D115333: [flang][codegen] Add a conversion for `fir.coordinate_of` - part 2

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added inline comments.


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:2854
+        if (!currentObjTy)
+          TODO(loc, "invalid coordinate/check failed");
+
----------------
rovka wrote:
> Is this really a TODO? Sounds more like an error...
Agree. I was trying to come up with an example that would get me here, but all of my invalid examples are detected earlier on.


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:2900
+    }
+    TODO(loc, "fir.coordinate_of base operand has unsupported type");
   }
----------------
rovka wrote:
> Error?
Probably. I was trying to come up with an example that would get me here, but all of my invalid examples are detected earlier on.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115333/new/

https://reviews.llvm.org/D115333