[PATCH] D115333: [flang][codegen] Add a conversion for `fir.coordinate_of` - part 2

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 15 03:48:00 PST 2021


awarzynski updated this revision to Diff 394517.
awarzynski marked 3 inline comments as done.
awarzynski added a comment.

- Renamed `validCoordinate` as `supportedCoordinate` (also added comments, renamed variables)
- Added a test for `fir.char` and `tuple`
- Added tests for TODOs and diagnostics
- Removed an assert that was duplicating a similar assert in FIROps.cpp


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115333/new/

https://reviews.llvm.org/D115333

Files:
  flang/lib/Optimizer/CodeGen/CodeGen.cpp
  flang/test/Fir/Todo/cordinate_of_5.fir
  flang/test/Fir/Todo/cordinate_of_6.fir
  flang/test/Fir/convert-to-llvm-invalid.fir
  flang/test/Fir/convert-to-llvm.fir
  flang/test/Fir/invalid.fir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115333.394517.patch
Type: text/x-patch
Size: 17786 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211215/0c5e9cfe/attachment.bin>


More information about the llvm-commits mailing list