[PATCH] D115623: [Debugify] Use DebugifyLevel in Debugify original mode

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added a comment.

In D115623#3194654 <https://reviews.llvm.org/D115623#3194654>, @StephenTozer wrote:

> Apologies, didn't see the existing comments on this review before submitting - given that the concern has been raised by another, it may be worth making a change to confirm that debug values have been dropped, and also check the error message. A simple way to do this might be to run the test twice, using `-debugify-level=locations-and-variables` for the second run, with a directive `CHECK: drops dbg.value()/dbg.declare()` - this should solve both issues by ensuring the test only passes if we are actually dropping debug info, and we are checking for the correct error message.

FWIW this suggestion sounds like a good solution to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115623/new/

https://reviews.llvm.org/D115623