[PATCH] D115623: [Debugify] Use DebugifyLevel in Debugify original mode
Stephen Tozer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 15 05:04:00 PST 2021
StephenTozer requested changes to this revision.
StephenTozer added a comment.
This revision now requires changes to proceed.
Apologies, didn't see the existing comments on this review before submitting - given that the concern has been raised by another, it may be worth making a change to confirm that debug values have been dropped, and also check the error message. A simple way to do this might be to run the test twice, using `-debugify-level=locations-and-variables` for the second run, with a directive `CHECK: drops dbg.value()/dbg.declare()` - this should solve both issues by ensuring the test only passes if we are actually dropping debug info, and we are checking for the correct error message.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115623/new/
https://reviews.llvm.org/D115623
More information about the llvm-commits
mailing list