[PATCH] D115458: [FuncSpec] Decouple Cost and Benefit analysis, to sort candidates. NFC.

[Chuanqi Xu via Phabricator via llvm-commits]

ChuanqiXu accepted this revision.
ChuanqiXu added a comment.
This revision is now accepted and ready to land.

If the score remains the same, it looks good to me. BTW, I think the change of `sort` matters. Previously, we banned a lot of cases which could have been specialized due to the consideration of the cost for code size and compilation time. But if we could sort them and assume we could have a good enough cost model (the current one might be coarse), then we could relax the restrictions we made previously to make function specialization more useful.
Nit: format codes before committing

(I suggest to commit this with D115509 <https://reviews.llvm.org/D115509> in one shot, but it doesn't really matter)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115458/new/

https://reviews.llvm.org/D115458