[PATCH] D115458: [FuncSpec] Decouple Cost and Benefit analysis, to sort candidates. NFC.

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added a comment.

I can confirm that the SPEC score with this patch and also with D115509 <https://reviews.llvm.org/D115509> remains the same, as expected and should be.

This is NFC as the resulting code should be the same, which is the definition of NFC I use. But yeah, I do agree of course that under the hood things work slightly different, although that will only have an affect in subsequent patches. Anyway, happy to remove NFC from the title.

> BTW, it might be better to add a test case to show the sort matters.

So it shouldn't matter here, but it's a good point and I will add an test-case for this to D115509 <https://reviews.llvm.org/D115509> as the affect will only be visible there.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115458/new/

https://reviews.llvm.org/D115458