[PATCH] D115007: Dump swift5 reflection section data into dsym bundle generated binary with dsymutil

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 14 13:37:59 PST 2021


aprantl added inline comments.


================
Comment at: llvm/include/llvm/MC/MCObjectFileInfo.h:234
+  std::array<MCSection *, 6> Swift5ReflectionSectionArr = {
+      nullptr, nullptr, nullptr, nullptr, nullptr, nullptr};
+
----------------
1. Instead of hardcoding 6, does `std::array<MCSection *, Swift5ReflectionSectionKind::Last> ` work?

2. `= {};` is shorter than listing all the nullptrs.

3. I would call this `Swift5ReflectionSections`



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115007/new/

https://reviews.llvm.org/D115007



More information about the llvm-commits mailing list