[PATCH] D115007: Dump swift5 reflection section data into dsym bundle generated binary with dsymutil

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/Swift.h:18
+#undef HANDLE_SWIFT_SECTION
+  Unknown = -1
+};
----------------
You could make this `Unknown, Last = Unknown` see comment below.


================
Comment at: llvm/include/llvm/MC/MCObjectFileInfo.h:436
+    return ReflSectionKind != llvm::swift::Swift5ReflectionSectionKind::Unknown
+               ? Swift5ReflectionSectionArr[ReflSectionKind]
+               : nullptr;
----------------
Nice.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115007/new/

https://reviews.llvm.org/D115007