[PATCH] D115699: [llvm-profgen] Skip disassembling for PLT section

Lei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 14 12:34:24 PST 2021


wlei added inline comments.


================
Comment at: llvm/test/tools/llvm-profgen/inline-noprobe2.test:76
 ;CHECK:   3: 5
-;CHECK: main:820:0
+quick_sort:903:25
+ 1: 24
----------------
hoy wrote:
> wenlei wrote:
> > wlei wrote:
> > > wenlei wrote:
> > > > are these test changes expected?
> > > Oh, sorry, it's the same to https://reviews.llvm.org/D115538, previously I removed by mistake. Let me removed this here.
> > If you put them in a stack, these earlier/unrelated changes won't show up. 
> > 
> > But still.. why are the remaining test changes, are they all due to PLT?
> Good question. Do the counters changed refer to PLT calls?
This patch is in the bottom of the patch stack. It appeared that those counter changes are all fixed by the following two patches. I guess it's due to the wrong leading external addr processing. let me confirm what's wrong.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115699/new/

https://reviews.llvm.org/D115699



More information about the llvm-commits mailing list