[PATCH] D115699: [llvm-profgen] Skip disassembling for PLT section

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/test/tools/llvm-profgen/inline-noprobe2.test:76
 ;CHECK:   3: 5
-;CHECK: main:820:0
+quick_sort:903:25
+ 1: 24
----------------
wenlei wrote:
> wlei wrote:
> > wenlei wrote:
> > > are these test changes expected?
> > Oh, sorry, it's the same to https://reviews.llvm.org/D115538, previously I removed by mistake. Let me removed this here.
> If you put them in a stack, these earlier/unrelated changes won't show up. 
> 
> But still.. why are the remaining test changes, are they all due to PLT?
Good question. Do the counters changed refer to PLT calls?


================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:557
 
+    if (SectionName == ".plt")
+      continue;
----------------
Move this above the `ShowDisassemblyOnly` check?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115699/new/

https://reviews.llvm.org/D115699