[PATCH] D115669: AMDGPU: Combine is.shared/is.private of null/undef

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstCombineIntrinsic.cpp:900
+
+    if (isa<ConstantPointerNull>(II.getArgOperand(0)))
+      return IC.replaceInstUsesWith(II, ConstantInt::getFalse(II.getType()));
----------------
arsenm wrote:
> rampitec wrote:
> > Why cannot we have a shared or private null pointer?
> The query is for whether the particular address points into the aperture. The null pointer doesn't point at anything, so therefore it doesn't point into the shared/private segment
You can have a flat pointer pointing exactly into the address zero of LDS or private. Aren't these addresses also null?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115669/new/

https://reviews.llvm.org/D115669