[PATCH] D115669: AMDGPU: Combine is.shared/is.private of null/undef

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstCombineIntrinsic.cpp:900
+
+    if (isa<ConstantPointerNull>(II.getArgOperand(0)))
+      return IC.replaceInstUsesWith(II, ConstantInt::getFalse(II.getType()));
----------------
rampitec wrote:
> Why cannot we have a shared or private null pointer?
The query is for whether the particular address points into the aperture. The null pointer doesn't point at anything, so therefore it doesn't point into the shared/private segment


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115669/new/

https://reviews.llvm.org/D115669