[PATCH] D115535: [libunwind] Provide a way to conveniently install libunwind headers

Mon Dec 13 06:54:10 PST 2021

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

I believe `unwind` should be made to depend on `unwind-header`, and `install-unwind` on `install-unwind-headers`.

Also, instead of `include_directories(include)` in `libunwind/CMakeLists.txt`, we should be able to `target_link_libraries(unwind_shared PRIVATE unwind-headers)` (and similarly for the static library). That will require adding `target_include_directories(unwind-headers INTERFACE <path-to-libunwind-include>)`.

================
Comment at: libunwind/include/CMakeLists.txt:17
+
+if(NOT CMAKE_CONFIGURATION_TYPES AND LIBUNWIND_INSTALL_LIBRARY)
+  add_custom_target(install-unwind-headers
----------------
Why do we have that check?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115535/new/

https://reviews.llvm.org/D115535