[PATCH] D115330: [Dexter] Allow tests to specify their command line options
Orlando Cazalet-Hyams via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 10 00:33:38 PST 2021
Orlando added a comment.
(Still LGTM)
================
Comment at: cross-project-tests/debuginfo-tests/dexter/dex/debugger/DebuggerControllers/DebuggerControllerBase.py:33
+ cmd_line_objs = commands['DexCommandLine']
+ assert len(cmd_line_objs) == 1
+ cmd_line_obj = cmd_line_objs[0]
----------------
jmorse wrote:
> Orlando wrote:
> > Probably a better user experience if this is caught in the parsing stage and prettily reported as an error. wdyt?
> I've added a filter to ParseCommand.py, which I think is the correct place for validating these things?
Thanks, and yeah that's the right place.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115330/new/
https://reviews.llvm.org/D115330
More information about the llvm-commits
mailing list