[PATCH] D115330: [Dexter] Allow tests to specify their command line options

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added inline comments.


================
Comment at: cross-project-tests/debuginfo-tests/dexter/dex/debugger/DebuggerControllers/DebuggerControllerBase.py:33
+            cmd_line_objs = commands['DexCommandLine']
+            assert len(cmd_line_objs) == 1
+            cmd_line_obj = cmd_line_objs[0]
----------------
Orlando wrote:
> Probably a better user experience if this is caught in the parsing stage and prettily reported as an error. wdyt?
I've added a filter to ParseCommand.py, which I think is the correct place for validating these things?


================
Comment at: cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/command_line.c:9-12
+  FILE *foo = fopen("/tmp/bees", "w");
+  fprintf(foo, "%d\n", argc);
+  fprintf(foo, "%s\n", argv[1]);
+  fclose(foo);
----------------
Orlando wrote:
> Is this part of the test (and the `#include`) necessary?
Yup, that was due to some testing, now removed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115330/new/

https://reviews.llvm.org/D115330