[PATCH] D115302: GlobalsModRef should treat functions w/o nosync conservatively.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 9 14:40:50 PST 2021


efriedma added a comment.

> Problem: not all intrinsics have been converted to use default attributes, so it will be a performance regression for them.

This could be a problem, yes.  Not sure how much of one it is in practice.

> Perhaps as a stop-gap workaround, we can explicitly enumerate NVPTX intrinsics that must be treated as a synchronization barrier.

I wouldn't really be happy with this, but I wouldn't block that patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115302/new/

https://reviews.llvm.org/D115302



More information about the llvm-commits mailing list