[PATCH] D115302: GlobalsModRef should treat functions w/o nosync conservatively.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

The bug being fixed here isn't exclusive to intrinsics.  The following shows the same issue using a spinloop:

  _Atomic int a = 0;
  static int z = 0;
  __attribute((noinline))
  void g(int x) {
     while (a != x);
  }
  int f(int x) {
     z = x;
     g(x);
     return z;
  }

Given that, I don't think this whole tangent about the control flow graph and hardcoding which intrinsics are nocallback is relevant to this bug.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115302/new/

https://reviews.llvm.org/D115302