[PATCH] D115391: Support: Avoid using SmallVector::set_size()
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 9 11:29:50 PST 2021
dblaikie added a comment.
In D115391#3181442 <https://reviews.llvm.org/D115391#3181442>, @dexonsmith wrote:
> In D115391#3180980 <https://reviews.llvm.org/D115391#3180980>, @dblaikie wrote:
>
>> Probably worth committing separately in case either causes breakage.
>
> Thanks for the review! Committed separately as 7df18557791ea1cf8f4f55d97d47ff5008f3bbbb <https://reviews.llvm.org/rG7df18557791ea1cf8f4f55d97d47ff5008f3bbbb> and cd7bc0e010a3c0b4eb349e8c9a0e7edd591a5fff <https://reviews.llvm.org/rGcd7bc0e010a3c0b4eb349e8c9a0e7edd591a5fff>.
>
> Just thinking now it'd have been better to //push// separately too -- likely you were implying that -- but at least now they're separately revertible.
Yeah - can be good to space them out so they get separate runs through CI - I don't always remember to do this either.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115391/new/
https://reviews.llvm.org/D115391
More information about the llvm-commits
mailing list