[PATCH] D112753: [llvm] [Support] Add CURL HTTP Client.

[Dimitry Andric via Phabricator via llvm-commits]

dim added subscribers: emaste, jrtc27, dim.
dim added a comment.

This breaks building on FreeBSD, where I see:

  -- Found LibXml2: /usr/local/lib/libxml2.so (found version "2.9.12")
  -- Looking for xmlReadMemory
  -- Looking for xmlReadMemory - found
  -- Found CURL: /usr/local/lib/libcurl.so (found version "7.79.1")
  -- Looking for curl_easy_init
  -- Looking for curl_easy_init - found
  -- Looking for el_init in edit
  -- Looking for el_init in edit - found
  ...

and then later:

  FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/HTTPClient.cpp.o
  /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/dim/obj/llvm-llvmorg-14-init-11213-ge0b259f22c00-freebsd13-amd64-ninja-clang-rel-1/lib/Support -I/home/dim/src/llvm/llvm-project/llvm/lib/Support -I/home/dim/obj/llvm-llvmorg-14-init-11213-ge0b259f22c00-freebsd13-amd64-ninja-clang-rel-1/include -I/home/dim/src/llvm/llvm-project/llvm/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections  -O3 -DNDEBUG -UNDEBUG -std=c++14  -fno-exceptions -fno-rtti -MD -MT lib/Support/CMakeFiles/LLVMSupport.dir/HTTPClient.cpp.o -MF lib/Support/CMakeFiles/LLVMSupport.dir/HTTPClient.cpp.o.d -o lib/Support/CMakeFiles/LLVMSupport.dir/HTTPClient.cpp.o -c /home/dim/src/llvm/llvm-project/llvm/lib/Support/HTTPClient.cpp
  /home/dim/src/llvm/llvm-project/llvm/lib/Support/HTTPClient.cpp:23:10: fatal error: 'curl/curl.h' file not found
  #include <curl/curl.h>
           ^~~~~~~~~~~~~
  1 error generated.

It looks like the -I flags aren't correctly detected, since it doesn't pass `-I/usr/local/include`, as it should:

  $ curl-config --cflags
  -I/usr/local/include
  
  $ curl-config --libs
  -L/usr/local/lib -lcurl


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112753/new/

https://reviews.llvm.org/D112753