[PATCH] D115259: [AArch64][SVE] Lower vector.insert to predicated SEL

Paul Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 9 03:31:59 PST 2021


paulwalker-arm accepted this revision.
paulwalker-arm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/CodeGen/AArch64/split-vector-insert.ll:56-59
 
 
+
+
----------------
Not sure why but I noticed that each new patch revision introduced a new blank line. Please remove them before committing.


================
Comment at: llvm/test/CodeGen/AArch64/split-vector-insert.ll:109-112
 
 
+
+
----------------
As above.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115259/new/

https://reviews.llvm.org/D115259



More information about the llvm-commits mailing list