[PATCH] D115259: [AArch64][SVE] Lower vector.insert to predicated SEL

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/insert-subvector-res-legalization.ll:165-171
+; CHECK-LABEL:   ptrue   p0.d
+; CHECK-LABEL:   ld1w    { z0.d }, p0/z, [x0]
+; CHECK-LABEL:   ldr     d1, [x1]
+; CHECK-LABEL:   ptrue   p0.d, vl2
+; CHECK-LABEL:   ushll   v1.2d, v1.2s, #0
+; CHECK-LABEL:   sel     z0.d, p0, z0.d, z1.d
+; CHECK-LABEL:   ret
----------------
These look like they should be `CHECK-NEXT:`?

Did `update_llc_test_checks.py` produce this output?


================
Comment at: llvm/test/CodeGen/AArch64/sve-insert-vector.ll:41-44
+; CHECK-LABEL    ptrue   p0.s, vl4
+; CHECK-LABEL                                    // kill: def $q1 killed $q1 def $z1
+; CHECK-LABEL    sel     z0.s, p0, z0.s, z1.s
+; CHECK-LABEL    ret
----------------
These look like they should be `CHECK-NEXT:`?


================
Comment at: llvm/test/CodeGen/AArch64/sve-insert-vector.ll:496-499
+; CHECK-NEXT     ptrue   p0.h, vl8
+; CHECK-NEXT     // kill: def $q1 killed $q1 def $z1
+; CHECK-NEXT     sel     z0.h, p0, z0.h, z1.h
+; CHECK-NEXT     ret
----------------
Missing `:` for `CHECK-NEXT:`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115259/new/

https://reviews.llvm.org/D115259