[PATCH] D110776: A new hidden option test-changed=exe that calls exe after each time IR changes

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks accepted this revision.
aeubanks added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:186
+// or "" if none.
+std::string prepareTempFiles(SmallVector<int> &FD, ArrayRef<StringRef> SR,
+                             SmallVector<std::string> &FileName) {
----------------
jamieschmeiser wrote:
> aeubanks wrote:
> > these should probably be returning `llvm::Error` instead of `std::string`
> Is llvm::Error applicable?  This isn't an error in user code but rather a failure in debug output and the error text returned is just reported as debug information.
`llvm::Error` is better typing than using a empty vs non-empty string, and it enforces that you check the return value
but doesn't really matter that much


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110776/new/

https://reviews.llvm.org/D110776