[PATCH] D110776: A new hidden option test-changed=exe that calls exe after each time IR changes

Jamie Schmeiser via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 6 12:13:15 PST 2021


jamieschmeiser added inline comments.


================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:186
+// or "" if none.
+std::string prepareTempFiles(SmallVector<int> &FD, ArrayRef<StringRef> SR,
+                             SmallVector<std::string> &FileName) {
----------------
aeubanks wrote:
> these should probably be returning `llvm::Error` instead of `std::string`
Is llvm::Error applicable?  This isn't an error in user code but rather a failure in debug output and the error text returned is just reported as debug information.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110776/new/

https://reviews.llvm.org/D110776



More information about the llvm-commits mailing list