[PATCH] D115227: [AMDGPU] Mark time intrinsics as nomem, hassideeffects

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/AMDGPU/SMInstructions.td:187
-  // corresponding to the IR attributes. The target intrinsics are
-  // considered as writing to memory for IR dependency purposes, but
-  // those can be modeled with hasSideEffects here. These also end up
----------------
foad wrote:
> Was there a reason the intrinsics weren't IntrHasSideEffects in the first place? (Did that property not exist?)
It didn't exist for most of history


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115227/new/

https://reviews.llvm.org/D115227