[PATCH] D115176: [ARM] Peek through And 1 in IsCMPZCSINC
Sjoerd Meijer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 7 02:17:38 PST 2021
SjoerdMeijer added inline comments.
================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:14623
+
+ // Ignore any zext and nodes that may not yet have been removed.
+ while (CSInc.getOpcode() == ISD::AND &&
----------------
The problem with these end-to-end test that we have for this code is that we are not testing things in isolation here, and that the patterns are difficult to see.... perhaps I am missing context or something else, but can you clarify with a "zext and" nodes is? I am just failing to see what the `AND 1` is doing here.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115176/new/
https://reviews.llvm.org/D115176
More information about the llvm-commits
mailing list