[PATCH] D115115: [doc] Fix namespace comment style in Coding Guidelines

[Aaron Ballman via Phabricator via llvm-commits]

aaron.ballman added a comment.

Given that both forms appear in the source code, the goal of the style guide rule here is to ensure it's clear that the reader knows which namespace is being closed, and that either form achieves that goal... should we bless both forms in the coding standard so nobody comes back and says "you have to change this"?

(My search for `// end namespace` brings up 1076 entries and `// namespace` brings up 2569 entries (both just searching over Clang), so it's unlikely we're ever going to get perfect consistency here anyway.)

In D115115#3173295 <https://reviews.llvm.org/D115115#3173295>, @carlosgalvezp wrote:

> Thanks! Do you know who should I tag as reviewer that has "authority" to approve the patch? I checked in `CODE_OWNERS.txt` but couldn't find anyone in charge of `docs`...

Pretty much any change to CodingStandards.rst should go through a wider community review anyway because there's not really one or two people who can make decisions for the whole community like that. I'd recommend an RFC (as annoying as those can be) to make sure there's consensus before moving forward. Once the community shows they're not strongly opposed to the change, then any trusted reviewer(s) can sign off on it because they can check the patch against the community intent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115115/new/

https://reviews.llvm.org/D115115