[PATCH] D115115: [doc] Fix namespace comment style in Coding Guidelines

MyDeveloperDay via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 6 06:09:22 PST 2021


MyDeveloperDay added subscribers: MaskRay, sammccall, RKSimon, dexonsmith, rnk.
MyDeveloperDay added a comment.

In D115115#3173295 <https://reviews.llvm.org/D115115#3173295>, @carlosgalvezp wrote:

> Thanks! Do you know who should I tag as reviewer that has "authority" to approve the patch? I checked in `CODE_OWNERS.txt` but couldn't find anyone in charge of `docs`...

I tend to look back at previous reviewers for files I don't normally edit, @sammccall , @MaskRay , @RKSimon , @dexonsmith , @rnk , these people have reviewed it before and have more clout than me, but I'm happy to LGTM from the aspect of keeping in line with what clang-format does by default. (which is why I saw this in the first place).

If you get no response I'm happy to come back and accept once we've given them time to take a look, at that point we can seek forgiveness rather than permission.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115115/new/

https://reviews.llvm.org/D115115



More information about the llvm-commits mailing list