[PATCH] D114423: [IR][VP] Extend the align param attr to vectors of pointers

Mon Dec 6 07:08:04 PST 2021

anna requested changes to this revision.
anna added a comment.
This revision now requires changes to proceed.

Actually looking at the patch again, you're mixing two concepts here:

1. fixing the LangRef and Attributes.cpp for `align` attribute on vector of pointers should be done as an independent patch. It is orthogonal to the SelectionDAGBuilder code and avoids the false dependency created by the parent patch linked to this patch.
2. ABI intrinsics and SelectionDAG builder changes can depend on the parent patch.

For #1, You need couple of tests for the attributes change and at least one in Verifier.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114423/new/

https://reviews.llvm.org/D114423