[PATCH] D114423: [IR][VP] Extend the align param attr to vectors of pointers

Mon Dec 6 07:02:09 PST 2021

anna added a comment.

In D114423#3173134 <https://reviews.llvm.org/D114423#3173134>, @frasercrmck wrote:

> Aha I just found D87304 <https://reviews.llvm.org/D87304> - maybe @jdoerfert @fhahn @anna @dantrushin would be interested in this patch.

Hi Fraser, 
Yes, this definitely unblocks some downstream only changes we had (basically partially reverting D87304 <https://reviews.llvm.org/D87304>) since we wanted to apply align to vector of pointers. I believe @jdoerfert wanted to see this applied to (at least one) other attribute apart from `align`. 
The LangRef update looks good and clear to me.

I think having this as a first step is good unblocks our use case downstream as well as yours. There were some IR compatibility changes landed in follow-up patch, attached to D87304 <https://reviews.llvm.org/D87304>. Are those relevant here?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114423/new/

https://reviews.llvm.org/D114423