[PATCH] D114646: [LV] Pass compare predicate to getCmpSelInstrCost.

Mon Dec 6 01:54:28 PST 2021

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!  D90070 <https://reviews.llvm.org/D90070> already mentioned that this should also be used in LV.

In D114646#3172854 <https://reviews.llvm.org/D114646#3172854>, @sdesmalen wrote:

> In D114646#3160680 <https://reviews.llvm.org/D114646#3160680>, @dmgreen wrote:
>
>> Makes sense to me, but I'm not sure what the original comment about being composed of different predicates meant.
>
> From what I can see, there's no tests that fail if we pass in the extra information, so even if this was the desired behaviour it isn't protected by any tests.
> Without clarification of that comment, I think we should pursue the thing in code that seems most sensible.

The comment referred to cases where there may not exist a context instruction (passed to `getCmpSelInstrCost`) or it may use a different predicate, but this shouldn't apply to the cases here.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114646/new/

https://reviews.llvm.org/D114646