[PATCH] D114646: [LV] Pass compare predicate to getCmpSelInstrCost.

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 6 01:32:34 PST 2021


sdesmalen added a comment.

In D114646#3160680 <https://reviews.llvm.org/D114646#3160680>, @dmgreen wrote:

> Makes sense to me, but I'm not sure what the original comment about being composed of different predicates meant.

>From what I can see, there's no tests that fail if we pass in the extra information, so even if this was the desired behaviour it isn't protected by any tests.
Without clarification of that comment, I think we should pursue the thing in code that seems most sensible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114646/new/

https://reviews.llvm.org/D114646



More information about the llvm-commits mailing list