[PATCH] D115127: [MIPS] Add FPU Delay Slot for MIPS1/2/3

[Simon Atanasyan via Phabricator via llvm-commits]

atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.

LGTM with some nits.



================
Comment at: llvm/lib/Target/Mips/MipsInstrInfo.cpp:576
+
+  if (HasFPUDelaySlot(MIInSlot)) {
+    return false;
----------------
Remove curly brackets here.


================
Comment at: llvm/lib/Target/Mips/MipsInstrInfo.cpp:590
+    if (Op.isReg()) {
+      std::pair<bool, bool> Rw =
+          MIInSlot.readsWritesVirtualRegister(Op.getReg());
----------------
You can use `std::tie` here and provide meaningful names instead of `Rw.first` and `Rw.second`.


================
Comment at: llvm/lib/Target/Mips/MipsInstrInfo.cpp:593
+
+      if (Rw.first || Rw.second) {
+        return false;
----------------
Remove curly brackets here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115127/new/

https://reviews.llvm.org/D115127