[PATCH] D115030: [mlir][OpenMP] omp.sections and omp.section lowering to LLVM IR

[Shraiysh via Phabricator via llvm-commits]

shraiysh added a comment.

Thanks for the review @NimishMishra.



================
Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:558
+
+  // TODO: Support the following clauses: private, firstprivate, lastprivate,
+  // reduction, allocate
----------------
NimishMishra wrote:
> Thanks for the patch @shraiysh. I have a question. `lastprivate` and `allocate` clauses are supported in PFT to MLIR lowering. Would there be any cause for any problem when we integrate the entire toolchain for sections construct?
As long as they are not supported in atleast one part of the toolchain, we cannot actually support those clauses and giving an error is better than generating a binary unexpected behavior. So, till there is support for these clauses here flang will not be able to support them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115030/new/

https://reviews.llvm.org/D115030