[PATCH] D115030: [mlir][OpenMP] omp.sections and omp.section lowering to LLVM IR

[Nimish Mishra via Phabricator via llvm-commits]

NimishMishra added a comment.

Thanks for the patch. LGTM



================
Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:558
+
+  // TODO: Support the following clauses: private, firstprivate, lastprivate,
+  // reduction, allocate
----------------
Thanks for the patch @shraiysh. I have a question. `lastprivate` and `allocate` clauses are supported in PFT to MLIR lowering. Would there be any cause for any problem when we integrate the entire toolchain for sections construct?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115030/new/

https://reviews.llvm.org/D115030