[PATCH] D106585: Fix clang debug info irgen of i128 enums

Fri Dec 3 11:08:24 PST 2021

aeubanks added a comment.

In D106585#3170019 <https://reviews.llvm.org/D106585#3170019>, @aeubanks wrote:

> In D106585#3169898 <https://reviews.llvm.org/D106585#3169898>, @rnk wrote:
>
>> This usage of isSameValue seems suspicious: https://github.com/llvm/llvm-project/blob/main/llvm/lib/IR/LLVMContextImpl.h#L389
>>
>> It seems to allow the possibility that APInts of differing bitwidth compare equal, but the hash value incorporates the bitwidth, so they may be inserted into differing hash buckets.
>
> yup, also checking the bit width makes the non-determinism go away, I'll send out a patch

https://reviews.llvm.org/D115054

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106585/new/

https://reviews.llvm.org/D106585