[PATCH] D106585: Fix clang debug info irgen of i128 enums

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

In D106585#3169898 <https://reviews.llvm.org/D106585#3169898>, @rnk wrote:

> This usage of isSameValue seems suspicious: https://github.com/llvm/llvm-project/blob/main/llvm/lib/IR/LLVMContextImpl.h#L389
>
> It seems to allow the possibility that APInts of differing bitwidth compare equal, but the hash value incorporates the bitwidth, so they may be inserted into differing hash buckets.

yup, also checking the bit width makes the non-determinism go away, I'll send out a patch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106585/new/

https://reviews.llvm.org/D106585