[PATCH] D114892: [llvm-dwarfdump] Do not print preceding :: for local types

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a subscriber: probinson.
dblaikie added a comment.

In D114892#3166220 <https://reviews.llvm.org/D114892#3166220>, @jhenderson wrote:

> The patch is more about testing generic DebugInfo behaviour, rather than anything specific to llvm-dwarfdump. I wonder if the test would make more sense there? No strong feelings on that though.

This comes back to the complication of debug info testing - llvm/test/DebugInfo has ended up as more a place for testing CodeGen/AsmPrinter - debug info generation, though, yeah, that's non-obvious. @probinson did point this out a while back that maybe the LLVM codegen tests should be moved into a different directory so llvm/test/DebugInfo could be used for testing libDebugInfo - and generally it was decided not to do that. I may have second thoughts on that, but generally I'd prefer pure libDebugInfoDWARF testing happen in llvm/test/tools/llvm-dwarfdump (& llvm/test/tools/llvm-symbolizer, etc) for now/these days unless we're going to move the codegen testing out of llvm/test/DebugInfo.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114892/new/

https://reviews.llvm.org/D114892