[PATCH] D114892: [llvm-dwarfdump] Do not print preceding :: for local types
Kristina Bessonova via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 2 03:50:09 PST 2021
krisb added a comment.
In D114892#3166220 <https://reviews.llvm.org/D114892#3166220>, @jhenderson wrote:
> The patch is more about testing generic DebugInfo behaviour, rather than anything specific to llvm-dwarfdump. I wonder if the test would make more sense there? No strong feelings on that though.
I placed the test into the same directory as the original `llvm/test/tools/llvm-dwarfdump/X86/prettyprint_types.s`, so if to change the directory it should be done for both tests, I think.
If so, I can move both tests in a separate NFC patch, but since there is no strong opinion on where to place these tests, I think this is up to @dblaikie.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114892/new/
https://reviews.llvm.org/D114892
More information about the llvm-commits
mailing list