[PATCH] D114913: [TLI checker] Add more tests

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: llvm/test/tools/llvm-tli-checker/Inputs/empty-coff.yaml:1
+## Minimal COFF input, with no symbols.
+--- !COFF
----------------
jhenderson wrote:
> Any particular reason this and empty-elf.yaml aren't inlined directly in the corresponding tests that use them?
I was originally thinking I'd include them in the archive test, but then I didn't, so yes they should be inlined into the tests that use them.


================
Comment at: llvm/test/tools/llvm-tli-checker/error-cases.test:17
+
+NOFILES: error: no input files
+
----------------
jhenderson wrote:
> Any particular reason this line is separated from the other checks?
Only that it isn't combined with other checks, and all the others are in combinations.


================
Comment at: llvm/test/tools/llvm-tli-checker/error-cases.test:19-22
+FILE-NOT-FOUND-DAG: : not found
+INVALID-FILE-DAG: The file was not recognized as a valid object file
+NOSYMBOLS-AT-ALL-DAG: NO symbols found!
+NOSYMBOLS-IN-FILE-DAG: : no symbols found
----------------
jhenderson wrote:
> I'd be inclined to include the full message, i.e. something like `error: [[FILE]]: not found` (or equivalent).
Right, I can use -D on the FileCheck command line to do that.


================
Comment at: llvm/test/tools/llvm-tli-checker/ps4-tli-check.yaml:46-47
 ## the exact count first; the two directives should add up to that.
+## Yes, this means additions to TLI will fail this test, but the argument
+## to -COUNT can't be an expression.
 # AVAIL: TLI knows 466 symbols, 235 available
----------------
jhenderson wrote:
> That's unfortunate. I don't suppose there's a way of doing some sort of fancy regex is there? (I can't immediately think of any).
A regex can have an exact count, but I don't think we can substitute a FileCheck numeric expression inside a regex, and that's what it would require.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114913/new/

https://reviews.llvm.org/D114913