[PATCH] D114913: [TLI checker] Add more tests

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Nice use of numeric variables by the way!



================
Comment at: llvm/test/tools/llvm-tli-checker/Inputs/empty-coff.yaml:1
+## Minimal COFF input, with no symbols.
+--- !COFF
----------------
Any particular reason this and empty-elf.yaml aren't inlined directly in the corresponding tests that use them?


================
Comment at: llvm/test/tools/llvm-tli-checker/error-cases.test:17
+
+NOFILES: error: no input files
+
----------------
Any particular reason this line is separated from the other checks?


================
Comment at: llvm/test/tools/llvm-tli-checker/error-cases.test:19-22
+FILE-NOT-FOUND-DAG: : not found
+INVALID-FILE-DAG: The file was not recognized as a valid object file
+NOSYMBOLS-AT-ALL-DAG: NO symbols found!
+NOSYMBOLS-IN-FILE-DAG: : no symbols found
----------------
I'd be inclined to include the full message, i.e. something like `error: [[FILE]]: not found` (or equivalent).


================
Comment at: llvm/test/tools/llvm-tli-checker/error-cases.test:23
+NOSYMBOLS-IN-FILE-DAG: : no symbols found
+
----------------
Nit: looks like you've got an extra blank line at EOF?


================
Comment at: llvm/test/tools/llvm-tli-checker/multi-file.yaml:34
+#
+## Also check that an archive works. Put file1/file2 into an archive,
+## and pass the archive name plus file3 on the command line.
----------------
I read `/` in this context as an "or" not "and" (and I could imagine others might initially read it as a directory separator).


================
Comment at: llvm/test/tools/llvm-tli-checker/multi-file.yaml:118
+    Binding:         STB_GLOBAL
+
----------------
Nit: looks like there's an additional blank line here?


================
Comment at: llvm/test/tools/llvm-tli-checker/ps4-tli-check.yaml:46-47
 ## the exact count first; the two directives should add up to that.
+## Yes, this means additions to TLI will fail this test, but the argument
+## to -COUNT can't be an expression.
 # AVAIL: TLI knows 466 symbols, 235 available
----------------
That's unfortunate. I don't suppose there's a way of doing some sort of fancy regex is there? (I can't immediately think of any).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114913/new/

https://reviews.llvm.org/D114913