[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data
Kristina Bessonova via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 2 04:35:21 PST 2021
krisb added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/MSP430.cpp:223-224
+ MCUData LoadedMCUData;
+ if (const Arg *MCUArg = Args.getLastArg(options::OPT_mmcu_EQ))
+ LoadedMCUData = getMCUData(MCUArg->getValue());
+
----------------
It might be worth moving this under `hwmult` option check, so we do not need to load MCU data again if the option is properly specificed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108301/new/
https://reviews.llvm.org/D108301
More information about the llvm-commits
mailing list