[PATCH] D114881: [TLI] Add memset_pattern4, memset_pattern8 lib functions.
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 1 12:18:00 PST 2021
fhahn marked an inline comment as done.
fhahn added inline comments.
================
Comment at: llvm/include/llvm/Analysis/TargetLibraryInfo.def:1051
TLI_DEFINE_STRING_INTERNAL("memset_pattern16")
+/// void memset_pattern4(void *b, const void *pattern4, size_t len);
+TLI_DEFINE_ENUM_INTERNAL(memset_pattern4)
----------------
ab wrote:
> nit: maybe keep it 4,8,16? (same in `TargetLibraryInfoTest.cpp`)
Unfortunately there is a check that assert that the values here are ordered lexigraphical and it seems to expect `memset_pattern16` before `memset_pattern4` :(
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114881/new/
https://reviews.llvm.org/D114881
More information about the llvm-commits
mailing list