[PATCH] D114881: [TLI] Add memset_pattern4, memset_pattern8 lib functions.
Ahmed Bougacha via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 1 10:22:04 PST 2021
ab accepted this revision.
ab added a comment.
This revision is now accepted and ready to land.
Makes sense, LGTM!
================
Comment at: llvm/include/llvm/Analysis/TargetLibraryInfo.def:1051
TLI_DEFINE_STRING_INTERNAL("memset_pattern16")
+/// void memset_pattern4(void *b, const void *pattern4, size_t len);
+TLI_DEFINE_ENUM_INTERNAL(memset_pattern4)
----------------
nit: maybe keep it 4,8,16? (same in `TargetLibraryInfoTest.cpp`)
================
Comment at: llvm/lib/Analysis/TargetLibraryInfo.cpp:190
} else if (!T.isWatchOS()) {
- TLI.setUnavailable(LibFunc_memset_pattern16);
+ TLI.setUnavailable(LibFunc_memset_pattern4);
+ TLI.setUnavailable(LibFunc_memset_pattern8);
----------------
+1 to the lint check ;)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114881/new/
https://reviews.llvm.org/D114881
More information about the llvm-commits
mailing list