[llvm] 84b978d - [LoopUnrollRuntime] Remove unnecessary pointer BECount check (NFC)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 1 01:33:12 PST 2021


Author: Nikita Popov
Date: 2021-12-01T10:32:37+01:00
New Revision: 84b978da3b80b986327a830c01e32f12cefe86b3

URL: https://github.com/llvm/llvm-project/commit/84b978da3b80b986327a830c01e32f12cefe86b3
DIFF: https://github.com/llvm/llvm-project/commit/84b978da3b80b986327a830c01e32f12cefe86b3.diff

LOG: [LoopUnrollRuntime] Remove unnecessary pointer BECount check (NFC)

BECounts are guaranteed to be integers nowadays.

Added: 
    

Modified: 
    llvm/lib/Transforms/Utils/LoopUnrollRuntime.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Utils/LoopUnrollRuntime.cpp b/llvm/lib/Transforms/Utils/LoopUnrollRuntime.cpp
index a92cb6a313d39..bb719a499a4cb 100644
--- a/llvm/lib/Transforms/Utils/LoopUnrollRuntime.cpp
+++ b/llvm/lib/Transforms/Utils/LoopUnrollRuntime.cpp
@@ -623,15 +623,13 @@ bool llvm::UnrollRuntimeLoopRemainder(
   if (!SE)
     return false;
 
-  // Only unroll loops with a computable trip count, and the trip count needs
-  // to be an int value (allowing a pointer type is a TODO item).
+  // Only unroll loops with a computable trip count.
   // We calculate the backedge count by using getExitCount on the Latch block,
   // which is proven to be the only exiting block in this loop. This is same as
   // calculating getBackedgeTakenCount on the loop (which computes SCEV for all
   // exiting blocks).
   const SCEV *BECountSC = SE->getExitCount(L, Latch);
-  if (isa<SCEVCouldNotCompute>(BECountSC) ||
-      !BECountSC->getType()->isIntegerTy()) {
+  if (isa<SCEVCouldNotCompute>(BECountSC)) {
     LLVM_DEBUG(dbgs() << "Could not compute exit block SCEV\n");
     return false;
   }


        


More information about the llvm-commits mailing list