[PATCH] D113289: LICM: Hoist LOAD without STORE

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a subscriber: nikic.
djtodoro added a comment.

@reames	Thanks a lot for the comments!



================
Comment at: llvm/include/llvm/Transforms/Utils/SSAUpdater.h:173
+
+  /// Used to indicate that we want to keep the store as is (since it was not
+  /// safe for sinking), by hoisting load only.
----------------
reames wrote:
> Make this comment generic.
> 
> e.g. Will return true if a sub-class wants to keep one of the loads or stores after SSA construction.  
Actually opposite, but it makes sense.


================
Comment at: llvm/test/Transforms/LICM/scalar-promote.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
 ; RUN: opt < %s -basic-aa -tbaa -licm -S | FileCheck %s
----------------
reames wrote:
> Please autogen this in a separate commit, then rebase your change over it so that diff is visible in commit.  
Sure. @nikic already addressed that with eee035235eb.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113289/new/

https://reviews.llvm.org/D113289