[PATCH] D113289: LICM: Hoist LOAD without STORE

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.

LGTM w/required changes before submission.



================
Comment at: llvm/include/llvm/Transforms/Utils/SSAUpdater.h:173
+
+  /// Used to indicate that we want to keep the store as is (since it was not
+  /// safe for sinking), by hoisting load only.
----------------
Make this comment generic.

e.g. Will return true if a sub-class wants to keep one of the loads or stores after SSA construction.  


================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:468
           LocalPromoted |= promoteLoopAccessesToScalars(
-              PointerMustAliases, ExitBlocks, InsertPts, MSSAInsertPts, PIC,
-              LI, DT, TLI, L, &MSSAU, &SafetyInfo, ORE);
+              PointerMustAliases, ExitBlocks, InsertPts, MSSAInsertPts, PIC, LI,
+              DT, TLI, L, &MSSAU, &SafetyInfo, ORE);
----------------
Whitespace only change - please remove.


================
Comment at: llvm/test/Transforms/LICM/scalar-promote.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
 ; RUN: opt < %s -basic-aa -tbaa -licm -S | FileCheck %s
----------------
Please autogen this in a separate commit, then rebase your change over it so that diff is visible in commit.  


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113289/new/

https://reviews.llvm.org/D113289