[PATCH] D114656: [ELF][PPC64] Remove unneeded PPC64PCRelLongBranchThunk
Nemanja Ivanovic via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 30 04:42:40 PST 2021
nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.
In D114656#3159300 <https://reviews.llvm.org/D114656#3159300>, @MaskRay wrote:
> PPC64R12SetupStub is not only used by NOTOC->TOC code, but is also used by NOTOC->NOTOC long branches, so `__long_branch_pcrel` is not that bad. That said, if `__gep_setup` makes more sense, I am happy to use it, too.
Ah yes, that's a good point. In fact, that is the more common use for this thunk (I neglected the fact that we are removing the check for `st_other > 1`).
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114656/new/
https://reviews.llvm.org/D114656
More information about the llvm-commits
mailing list