[PATCH] D114656: [ELF][PPC64] Remove unneeded PPC64PCRelLongBranchThunk

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 29 12:49:41 PST 2021


MaskRay added a comment.

In D114656#3158291 <https://reviews.llvm.org/D114656#3158291>, @nemanjai wrote:

> How important is it for the thunk symbol names to match `ld.bfd/ld.gold`?

Not important. If linkers can have a common name which is reasonable to both parties, I am happy to do so so that users would need to learn less stuff.

PPC64R12SetupStub is not only used by NOTOC->TOC code, but is also used by NOTOC->NOTOC long branches, so `__long_branch_pcrel` is not that bad. That said, if `__gep_setup` makes more sense, I am happy to use it, too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114656/new/

https://reviews.llvm.org/D114656



More information about the llvm-commits mailing list