[PATCH] D114630: [fir] Get rid of the global option in FIRBuilder
Kiran Chandramohan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 29 08:01:24 PST 2021
kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.
In D114630#3158447 <https://reviews.llvm.org/D114630#3158447>, @clementval wrote:
> In D114630#3158446 <https://reviews.llvm.org/D114630#3158446>, @kiranchandramohan wrote:
>
>> Was the suggestion to use a dialect attribute/constant?
>
> It is currently not used so always `32` so a simple constexpr should be enough, no?
Ah OK, if it is not used then it is fine with me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114630/new/
https://reviews.llvm.org/D114630
More information about the llvm-commits
mailing list