[PATCH] D114630: [fir] Get rid of the global option in FIRBuilder

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 29 07:59:07 PST 2021


clementval added a comment.

In D114630#3158446 <https://reviews.llvm.org/D114630#3158446>, @kiranchandramohan wrote:

> Was the suggestion to use a dialect attribute/constant?

It is currently not used so always `32` so a simple constexpr should be enough, no?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114630/new/

https://reviews.llvm.org/D114630



More information about the llvm-commits mailing list